Unpin electron and electron-builder dependencies #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d--updater-version-forward
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5230 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 94 94
Lines 34215 34215
=======================================
Hits 29342 29342
Misses 4873 4873
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…d--updater-version-forward
…d--updater-version-forward
…d--updater-version-forward
pierremtb
changed the title
|
Thanks @lf94. Will force merge since the cargo test failure has nothing to do with this. |
pierremtb
deleted the
pierremtb/issue4505-Bump-electron-builder-and--updater-version-forward
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had them pinned after the electron-updater scare a few releases ago. With the smoke tests we have in place now for release I believe we should let it move forward electron version wise.
Tested: